Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mobile adapter #882

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Update mobile adapter #882

wants to merge 17 commits into from

Conversation

Funkatronics
Copy link
Contributor

No description provided.

@Funkatronics
Copy link
Contributor Author

@jordaaash I think I got our libs all fixed up. This branch is currently using @solana-mobile/wallet-adapter-mobile v2.1.0-alpha1 and its building a testing both locally and on CI (I think)

I am going to test this alpha build a bit more then publish a proper 2.1.0 release and update this PR

@socket-security Socket Security
Copy link

socket-security bot commented Jan 19, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@solana-mobile/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +592 184 MB

🚮 Removed packages: npm/@solana-mobile/[email protected]

View full report↗︎

@Funkatronics Funkatronics changed the title [WIP] Update mobile adapter Update mobile adapter Jan 19, 2024
@Funkatronics
Copy link
Contributor Author

@jsx bump. Do you have any concerns with merging this?

jordaaash
jordaaash reviewed Feb 28, 2024
View reviewed changes
pnpm-lock.yaml Outdated
dependencies:
'@wallet-standard/base': 1.0.1
'@wallet-standard/features': 1.0.3
dev: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're resolving multiple versions of some packages now, it might be something on our end. Looking into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lmk if I can help

@Funkatronics
Copy link
Contributor Author

Funkatronics commented Apr 22, 2024 •
edited
Loading

@jordaaash there are a couple remaining dupes:

/@solana/[email protected](@solana/[email protected])([email protected])
/@solana/[email protected](@solana/[email protected])([email protected])

and

/@solana/[email protected](@solana/wallet-adapter-base@packages+core+base)(@solana/[email protected])([email protected])([email protected])
/@solana/[email protected](@solana/wallet-adapter-base@packages+core+base)(@solana/[email protected])([email protected])([email protected])

due to bs58 differences. @solana-mobile/mobile-wallet-adapter-protocol-web3js uses [email protected], while @solana/wallet-standard-wallet-adapter-base uses [email protected]. I have not been able to resolve this without changing the dependency on our end.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaaash jordaaash jordaaash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Funkatronics @jordaaash